Skip to content

Phoenix dep, Application boundaries for Elixir 1.11.x #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Phoenix dep, Application boundaries for Elixir 1.11.x #104

wants to merge 2 commits into from

Conversation

tmartin8080
Copy link

@tmartin8080 tmartin8080 commented Jan 17, 2021 •
edited
Loading

There are some application boundary warnings for Elixir 1.11.x and some other misc changes.

After updating, there were some failing tests which seem to be related to generating a tags:

 [60, "a", [[32, "class", 61, 34, "", 34]], 62, "1", 60, 47, "a", 62],
 [60, "a", [[32, "class", 61, 34, [], 34]], 62, "1", 60, 47, "a", 62],

I'll look more into this, but wanted to get a PR started.
Free to to chime in on what the implications of [] vs "" might be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tmartin8080